[
https://issues.apache.org/jira/browse/LUCENE-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604250#comment-13604250
]
Shai Erera commented on LUCENE-4752:
------------------------------------
Adrien, I think that the change to LTC is a bit of an overkill. It doesn't test
any new functionality except that you can sub-class SegmentMerger. Yet it did
cause you to track down tests that might by affected b/c e.g. they are already
slow tests and it will make them slower. Therefore I think that we should test
this extensibility in a separate, dedicated test, which e.g. sub-classes SM and
say reorders the list of atomic readers, so that we're sure this sub-classing
not only compiled, but actually did something different than if we didn't
sub-class.
Also, Robert made this comment:
bq. SegmentWriteState's fieldinfos should be final. Some of these little things
took a long time to accomplish to give us a great deal of safety inside lucene
internally.
Is it possible to make fieldInfos final? Since sorting segments has nothing to
do with field infos (all that we need is to wrap the readers with SortingAR),
we should only modify what's absolutely necessary to accomplish that.
> Merge segments to sort them
> ---------------------------
>
> Key: LUCENE-4752
> URL: https://issues.apache.org/jira/browse/LUCENE-4752
> Project: Lucene - Core
> Issue Type: New Feature
> Components: core/index
> Reporter: David Smiley
> Assignee: Adrien Grand
> Attachments: LUCENE-4752.patch
>
>
> It would be awesome if Lucene could write the documents out in a segment
> based on a configurable order. This of course applies to merging segments
> to. The benefit is increased locality on disk of documents that are likely to
> be accessed together. This often applies to documents near each other in
> time, but also spatially.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
