[ 
https://issues.apache.org/jira/browse/LUCENE-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604272#comment-13604272
 ] 

Adrien Grand commented on LUCENE-4752:
--------------------------------------

bq. Is it possible to make fieldInfos final?

Sure. I removed the final keyword because it was easier to hack up a quick 
patch but this can definitely be fixed.

bq. Adrien, perhaps add a SortingSegmentMerger to the sorter package? Or at 
least add a test that verifies merges keep things sorted?

I'll do that in the next patches!

bq. And finally i think it would be way better to provide whatever 'hook' is 
needed for this kinda stuff rather than allow subclassing of segmentmerger.

I'm fine with that option too, I need to think more about how to name it and 
where to plug it.

In addition to the API, I think something important to validate is whether 
sorting the segments to merge is viable and doesn't blow up memory or indexing 
time... I started working on this (LUCENE-4830 for memory and LUCENE-4839 for 
complexity) and will run some indexing benchmarks with the Wikipedia corpus to 
see how it behaves compared to natural merging.

                
> Merge segments to sort them
> ---------------------------
>
>                 Key: LUCENE-4752
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4752
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: core/index
>            Reporter: David Smiley
>            Assignee: Adrien Grand
>         Attachments: LUCENE-4752.patch
>
>
> It would be awesome if Lucene could write the documents out in a segment 
> based on a configurable order.  This of course applies to merging segments 
> to. The benefit is increased locality on disk of documents that are likely to 
> be accessed together.  This often applies to documents near each other in 
> time, but also spatially.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to