[ 
https://issues.apache.org/jira/browse/LUCENE-4752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13604530#comment-13604530
 ] 

Shai Erera commented on LUCENE-4752:
------------------------------------

This looks less invasive indeed, but I feel that MP.reorder() is kind of out of 
the blue. Maybe we should find a way to stuff it into OneMerge? I.e.:

* Make OneMerge readers private and add a method {{add(AtomicReader)}} which 
will be called by IW
* Add OneMerge.getReaders() returns a List<AtomicReader>
* IW.mergeMiddle() won't add the readers to SegmentMerger directly, but rather 
accumulate them in OneMerge and then just before it calls merger.merge() it 
will either do merger.add(oneMerge.getReaders()) (requires changing SM to take 
a list of readers, not one at a time), or if we don't want to touch SM, just 
add the returned readers one at a time.
* Then SortingMP will return its own OneMerge that wraps all the readers by 
SortingAR.

What do you think?
                
> Merge segments to sort them
> ---------------------------
>
>                 Key: LUCENE-4752
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4752
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: core/index
>            Reporter: David Smiley
>            Assignee: Adrien Grand
>         Attachments: LUCENE-4752.patch, LUCENE-4752.patch
>
>
> It would be awesome if Lucene could write the documents out in a segment 
> based on a configurable order.  This of course applies to merging segments 
> to. The benefit is increased locality on disk of documents that are likely to 
> be accessed together.  This often applies to documents near each other in 
> time, but also spatially.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to