[ 
https://issues.apache.org/jira/browse/LUCENE-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793029#comment-13793029
 ] 

Robert Muir commented on LUCENE-5274:
-------------------------------------

{quote}
Sure! I'm more used to Guava's tools so I think I was lulled in to a false 
sense of recognition. No chance of updating to a modern version of Guava?
{quote}

There is no lucene dependency on guava. I don't think we should introduce one, 
and it wouldnt solve the issues i mentioned anyway (e.g. comparable 
inconsistent with equals and stuff). It would only add 2.1MB of bloated 
unnecessary syntactic sugar (sorry, thats just my opinion on it, i think its 
useless).

We should keep our third party dependencies minimal and necessary so that any 
app using lucene can choose for itself what version of this stuff (if any) it 
wants to use. If we rely upon unnecessary stuff it hurts the end user by 
forcing them to compatible versions.


> Teach fast FastVectorHighlighter to highlight "child fields" with parent 
> fields
> -------------------------------------------------------------------------------
>
>                 Key: LUCENE-5274
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5274
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/other
>            Reporter: Nik Everett
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-5274.patch
>
>
> I've been messing around with the FastVectorHighlighter and it looks like I 
> can teach it to highlight matches on "child fields".  Like this query:
> foo:scissors foo_exact:running
> would highlight foo like this:
> <em>running</em> with <em>scissors</em>
> Where foo is stored WITH_POSITIONS_OFFSETS and foo_plain is an unstored copy 
> of foo a different analyzer and its own WITH_POSITIONS_OFFSETS.
> This would make queries that perform weighted matches against different 
> analyzers much more convenient to highlight.
> I have working code and test cases but they are hacked into Elasticsearch.  
> I'd love to Lucene-ify if you'll take them.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to