[
https://issues.apache.org/jira/browse/LUCENE-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798550#comment-13798550
]
Adrien Grand commented on LUCENE-5274:
--------------------------------------
bq. As for WeightedPhraseInfo's immutability - I didn't see any final members
so setting up the state in the constructor and not having setters just looked
more like it wanted to encapsulate logic rather than immutability.
I don't know if it was initially designed to be immutable, it's just the fact
that 'text' was computed in the constructor and that this class had no method
that mutates data that made me think so. But since immutable objects are easier
to work with, maybe we should make this class immutable.
bq. I'll swap the merge method with a merging constructor.
OK
> Teach fast FastVectorHighlighter to highlight "child fields" with parent
> fields
> -------------------------------------------------------------------------------
>
> Key: LUCENE-5274
> URL: https://issues.apache.org/jira/browse/LUCENE-5274
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Reporter: Nik Everett
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-5274.patch
>
>
> I've been messing around with the FastVectorHighlighter and it looks like I
> can teach it to highlight matches on "child fields". Like this query:
> foo:scissors foo_exact:running
> would highlight foo like this:
> <em>running</em> with <em>scissors</em>
> Where foo is stored WITH_POSITIONS_OFFSETS and foo_plain is an unstored copy
> of foo a different analyzer and its own WITH_POSITIONS_OFFSETS.
> This would make queries that perform weighted matches against different
> analyzers much more convenient to highlight.
> I have working code and test cases but they are hacked into Elasticsearch.
> I'd love to Lucene-ify if you'll take them.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
