[
https://issues.apache.org/jira/browse/LUCENE-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13798512#comment-13798512
]
Nik Everett commented on LUCENE-5274:
-------------------------------------
{quote}
(it removed MergedIterator.java)
{quote}
It was supposed to move it to the util package. I'll figure out what happened
there.
I agree with the other points but it is worth discussing the last one. The
others I'll just make the changes you mention.
I intentionally didn't update text in WeightedPhraseInfo.merge because it is
documented as being for debugging so it didn't seem worth the cost. Would it
make sense to remove the member entirely and generate it from stored terms when
needed?
It also doesn't update seqnum mostly because I really don't know the right way
to update it.
As for WeightedPhraseInfo's immutability - I didn't see any final members so
setting up the state in the constructor and not having setters just looked more
like it wanted to encapsulate logic rather than immutability. I'll swap the
merge method with a merging constructor.
> Teach fast FastVectorHighlighter to highlight "child fields" with parent
> fields
> -------------------------------------------------------------------------------
>
> Key: LUCENE-5274
> URL: https://issues.apache.org/jira/browse/LUCENE-5274
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/other
> Reporter: Nik Everett
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-5274.patch
>
>
> I've been messing around with the FastVectorHighlighter and it looks like I
> can teach it to highlight matches on "child fields". Like this query:
> foo:scissors foo_exact:running
> would highlight foo like this:
> <em>running</em> with <em>scissors</em>
> Where foo is stored WITH_POSITIONS_OFFSETS and foo_plain is an unstored copy
> of foo a different analyzer and its own WITH_POSITIONS_OFFSETS.
> This would make queries that perform weighted matches against different
> analyzers much more convenient to highlight.
> I have working code and test cases but they are hacked into Elasticsearch.
> I'd love to Lucene-ify if you'll take them.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
