I'm pretty sure pull requests close over the current branch revision, so there's no way to post ipso facto modify them from the sender's perspective.
Michael Della Bitta Applications Developer o: +1 646 532 3062 | c: +1 917 477 7906 appinions inc. “The Science of Influence Marketing” 18 East 41st Street New York, NY 10017 t: @appinions <https://twitter.com/Appinions> | g+: plus.google.com/appinions<https://plus.google.com/u/0/b/112002776285509593336/112002776285509593336/posts> w: appinions.com <http://www.appinions.com/> On Sat, Jan 4, 2014 at 1:25 PM, Shawn Heisey <[email protected]> wrote: > On 1/4/2014 9:23 AM, Jan Høydahl wrote: > > Another beauty of PRs (at least at GitHub) is that the contributor can > > continue improving the fix in his branch through small incremental > > commits, and this will be included in the pull without the need for > > another PR. > > This actually might be considered a detriment. Let's say that you're > someplace you can review a change but not apply it. So you review it > and determine that it's good. Then the patch creator changes it in a > way that you don't find acceptable, but still passes all the tests. > > Later, when you arrive at home/work/other and can actually do something > with it, is there any obvious way for you to know that it has changed > and needs another review? If at that point you pull the change, commit > it locally, and push it to the repo, it won't be what you've already > reviewed. > > Of course, a smart committer won't ever push anything without a > comprehensive final review, but everyone has times when they are in a > rush to get things done. > > I'm wondering if my +1 might have been a little hasty. :) > > Thanks, > Shawn > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
