paulirwin commented on code in PR #930:
URL: https://github.com/apache/lucenenet/pull/930#discussion_r1523550095
##########
src/dotnet/tools/lucene-cli/lucene-cli.csproj:
##########
@@ -24,22 +24,22 @@
<Import Project="$(SolutionDir).build/nuget.props" />
<PropertyGroup>
- <TargetFrameworks>net7.0;net6.0</TargetFrameworks>
- <RollForward Condition=" $(TargetFramework.StartsWith('net7.'))
">Major</RollForward>
+ <TargetFrameworks>net8.0;net6.0</TargetFrameworks>
+ <RollForward Condition=" $(TargetFramework.StartsWith('net8.'))
">Major</RollForward>
Review Comment:
How about we remove this for now? There's no guarantee that this tool will
work well in .NET 9, .NET 9 is a STS release so the likelihood that a user only
has that installed and not .NET 8 are low, and users can [override the
roll-forward
behavior](https://learn.microsoft.com/en-us/dotnet/core/versions/selection#control-roll-forward-behavior)
if they really wanted to run this on a machine without .NET 8 installed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
