paulirwin commented on code in PR #930:
URL: https://github.com/apache/lucenenet/pull/930#discussion_r1523828787
##########
src/dotnet/tools/lucene-cli/lucene-cli.csproj:
##########
@@ -24,22 +24,22 @@
<Import Project="$(SolutionDir).build/nuget.props" />
<PropertyGroup>
- <TargetFrameworks>net7.0;net6.0</TargetFrameworks>
- <RollForward Condition=" $(TargetFramework.StartsWith('net7.'))
">Major</RollForward>
+ <TargetFrameworks>net8.0;net6.0</TargetFrameworks>
+ <RollForward Condition=" $(TargetFramework.StartsWith('net8.'))
">Major</RollForward>
Review Comment:
I agree with leaving this as the Major roll-forward strategy, and I
appreciate the amount of thought you've put into this. But if we can't test
effectively with .NET 9 because we don't know what will break in the future,
then by definition we just have to accept the risk that a future .NET version
will break it for now and leave this as-is. It's already in the repo, so it's
not like this PR changes anything from the current state in this regard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
