paulirwin commented on code in PR #930:
URL: https://github.com/apache/lucenenet/pull/930#discussion_r1523915432
##########
src/dotnet/tools/lucene-cli/lucene-cli.csproj:
##########
@@ -24,22 +24,22 @@
<Import Project="$(SolutionDir).build/nuget.props" />
<PropertyGroup>
- <TargetFrameworks>net7.0;net6.0</TargetFrameworks>
- <RollForward Condition=" $(TargetFramework.StartsWith('net7.'))
">Major</RollForward>
+ <TargetFrameworks>net8.0;net6.0</TargetFrameworks>
+ <RollForward Condition=" $(TargetFramework.StartsWith('net8.'))
">Major</RollForward>
Review Comment:
Alright, good and maybe weird results. I set up a fresh Ubuntu VM and only
installed the .NET 8 SDK onto it. I installed the global tool with `dotnet tool
install --global lucene-cli --version 4.8.0-beta00016`. If you just run
`lucene`, you get the error that you must install .NET 6 (which is the weird
part, maybe it prefers LTS to STS .NET 7?).
However, the options at the link I sent before _do_ work for global tools.
You can force it to run on .NET 8 with `lucene --roll-forward LatestMajor`. For
example, `lucene --roll-forward LatestMajor benchmark sample` works. Note that
Major does not work, only `LatestMajor`. You also can override it without the
CLI flag by setting the `DOTNET_ROLL_FORWARD` environment variable to
`LatestMajor`.
Given that it does work to override it manually with the tool installation,
I'd say we can either remove this, or try setting the roll forward strategy to
LatestMajor (although that might be a little risky, and not what some users
want). My vote would be for the former and remove the explicit strategy,
defaulting to Minor, letting users override it if they wish.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
