NightOwl888 commented on code in PR #930:
URL: https://github.com/apache/lucenenet/pull/930#discussion_r1523849517
##########
src/dotnet/tools/lucene-cli/lucene-cli.csproj:
##########
@@ -24,22 +24,22 @@
<Import Project="$(SolutionDir).build/nuget.props" />
<PropertyGroup>
- <TargetFrameworks>net7.0;net6.0</TargetFrameworks>
- <RollForward Condition=" $(TargetFramework.StartsWith('net7.'))
">Major</RollForward>
+ <TargetFrameworks>net8.0;net6.0</TargetFrameworks>
+ <RollForward Condition=" $(TargetFramework.StartsWith('net8.'))
">Major</RollForward>
Review Comment:
Right. What I meant was to build the master branch before we merge this one.
Then on a machine with no lower SDK than 8.0, work out how to install
lucene-cli from the NuGet package using the roll forward strategy so a command
will run, then document that scenario for posterity to install is after planned
obsolescence of the runtime it shipped with.
Ron helped out with this before, and we discovered you must specify to use
the new runtime explicitly or it will install but fail to run. I wish they had
made it automatically use the latest installed runtime, but maybe you are right
that some apps may have compatibility problems with the new runtime. Ours
shouldn't, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
