kaknikhil commented on a change in pull request #451: DL: Update evaluate and
predict for multi model outputs
URL: https://github.com/apache/madlib/pull/451#discussion_r336613458
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras_predict.py_in
##########
@@ -162,6 +165,8 @@ class Predict(BasePredict):
self.validate()
BasePredict.call_internal_keras(self)
+ if self.mst_key:
+ plpy.execute("DROP VIEW IF EXISTS
{}".format(self.model_summary_table))
Review comment:
It's a bit confusing to read that we are dropping the model summary table. I
understand that we overwrite this variable with the temp summary view.
I think it would be better if we use a different variable instead of
overwriting the same one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
