kaknikhil commented on a change in pull request #451: DL: Update evaluate and
predict for multi model outputs
URL: https://github.com/apache/madlib/pull/451#discussion_r336616488
##########
File path:
src/ports/postgres/modules/deep_learning/test/madlib_keras_evaluate.sql_in
##########
@@ -59,3 +61,44 @@ ALTER TABLE keras_saved_out DROP COLUMN model_arch;
SELECT assert(trap_error($TRAP$
SELECT madlib_keras_evaluate('keras_saved_out', 'cifar_10_sample_val',
'evaluate_out');
$TRAP$) = 1, 'Should error out if model_arch column is missing from
model_table');
+
+
+
+m4_changequote(`<!', `!>')
+m4_ifdef(<!__POSTGRESQL__!>, <!!>, <!
+
+DROP TABLE IF EXISTS mst_table, mst_table_summary;
+SELECT load_model_selection_table(
+ 'model_arch',
+ 'mst_table',
+ ARRAY[1],
+ ARRAY[
+
$$loss='categorical_crossentropy',optimizer='Adam(lr=0.1)',metrics=['accuracy']$$,
+ $$loss='categorical_crossentropy',
optimizer='Adam(lr=0.01)',metrics=['accuracy']$$,
+
$$loss='categorical_crossentropy',optimizer='Adam(lr=0.001)',metrics=['accuracy']$$
+ ],
+ ARRAY[
+ $$batch_size=5,epochs=1$$,
+ $$batch_size=10,epochs=1$$
+ ]
+);
+
Review comment:
Do you think it makes sense to add test cases for the following scenarios ?
(same goes for predict)
1. When mst_key is passed as NULL for multi model evaluate
1. When mst_key is passed as NON NULL for single model evaluate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
