kaknikhil commented on a change in pull request #451: DL: Update evaluate and
predict for multi model outputs
URL: https://github.com/apache/madlib/pull/451#discussion_r335204569
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -557,20 +565,29 @@ def get_segments_and_gpus(gpus_per_host):
return segments_per_host, gpus_per_host
-def evaluate(schema_madlib, model_table, test_table, output_table,
gpus_per_host, **kwargs):
+def evaluate(schema_madlib, model_table, test_table, output_table,
+ gpus_per_host, mst_key, **kwargs):
+
module_name = 'madlib_keras_evaluate'
+ is_mult_model = mst_key is not None
if test_table:
test_summary_table = add_postfix(test_table, "_summary")
model_summary_table = None
if model_table:
model_summary_table = add_postfix(model_table, "_summary")
- validate_evaluate(module_name, model_table, model_summary_table,
test_table, test_summary_table, output_table)
+ mult_where_clause = ""
+ if is_mult_model:
+ mult_where_clause = "WHERE mst_key = {0}".format(mst_key)
Review comment:
do we need to validate that mst_key in not null when is_mult_model is true ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
