kaknikhil commented on a change in pull request #451: DL: Update evaluate and
predict for multi model outputs
URL: https://github.com/apache/madlib/pull/451#discussion_r335204361
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -466,9 +466,9 @@ def fit_transition(state, dependent_var, independent_var,
dependent_var_shape,
SD = kwargs['SD']
device_name = get_device_name_and_set_cuda_env(gpus_per_host,
current_seg_id)
- if is_multiple_model:
- prev_serialized_weights = madlib_keras_serializer.\
- get_serialized_1d_weights_from_state(prev_serialized_weights)
+ # if is_multiple_model:
Review comment:
Can we remove this commented out code ? We should also explain the
motivation behind removing this if check in the commit message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
