Am 01/08/17 um 02:43 schrieb Christian Schulte: > Am 01/08/17 um 01:27 schrieb Tibor Digana: >> You committed right after me and you have reverted two Jira issue. > > This would not have been possible. What reverts are you talking about. I > am locking at > <https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git>. > >> I do not want to continue until we make agreement. >> If you want to see thrown IOException, then we can use InputStream.close() >> instead of IOUtils.close(). >> Please nobody commit until we know what we clarify. > > Have you read the Javadoc of the 'closeQuietly' methods as I suggested? > <http://commons.apache.org/proper/commons-io/javadocs/api-release/org/apache/commons/io/IOUtils.html> > > Looking at the commits, I get the impression, you haven't got the point > in closing resources on failure and again added things suppressing > exceptions not to ignore. > >> Except for PrintWriter there is again all old staff back like missed >> flush(), etc. > > There are no missing flush calls. Where?
I really need to know about that. There may be missing close calls. Allright. Those calls are really missing then or there will be resource leaks all around. --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
