Hi, I propose to improve [1] to add a code style for our pom files. As the following tags are required: modelVersion, groupId, artifactId and version (see [2]), I see the following in this order.
<project> <modelVersion/> <parent/> if required <groupId/> <artifactId/> <version/> <name/> <description/> <prerequisites/> if required <scm/> <issueManagement/> <dependencies/> <build/> if required <reporting/> if required <profiles/> if required <properties/> if required </project> My reasoning is mainly based on the consistency and the maintenance. WDYT? Vincent [1] http://maven.apache.org/guides/development/guide-m2-development.html [2] http://maven.apache.org/guides/introduction/introduction-to-the-pom.html#Minimal_POM ---------- Forwarded message ---------- From: <[EMAIL PROTECTED]> Date: 2008/6/21 Subject: svn commit: r670264 - /maven/plugins/trunk/maven-site-plugin/pom.xml To: [EMAIL PROTECTED] Author: dennisl Date: Sat Jun 21 15:00:07 2008 New Revision: 670264 URL: http://svn.apache.org/viewvc?rev=670264&view=rev Log: o Reorder POM elements. Modified: maven/plugins/trunk/maven-site-plugin/pom.xml Modified: maven/plugins/trunk/maven-site-plugin/pom.xml URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/pom.xml?rev=670264&r1=670263&r2=670264&view=diff ============================================================================== --- maven/plugins/trunk/maven-site-plugin/pom.xml (original) +++ maven/plugins/trunk/maven-site-plugin/pom.xml Sat Jun 21 15:00:07 2008 @@ -19,18 +19,17 @@ --> <project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd";> - <modelVersion>4.0.0</modelVersion> - <parent> <artifactId>maven-plugins</artifactId> <groupId>org.apache.maven.plugins</groupId> <version>11</version> </parent> + <modelVersion>4.0.0</modelVersion> <artifactId>maven-site-plugin</artifactId> - <version>2.0-beta-7-SNAPSHOT</version> <packaging>maven-plugin</packaging> <name>Maven Site Plugin</name> + <version>2.0-beta-7-SNAPSHOT</version> <description> The Maven Site Plugin is a plugin that generates a site for the current project. </description> @@ -148,6 +147,64 @@ <url>http://svn.apache.org/viewvc/maven/plugins/trunk/maven-site-plugin/</url> </scm> + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-plugin-plugin</artifactId> + <version>2.4.2-SNAPSHOT</version> + </plugin> + <plugin> + <artifactId>maven-surefire-plugin</artifactId> + <version>2.3</version> + </plugin> + </plugins> + </build> + + <profiles> + <profile> + <id>integration-tests</id> + <activation> + <property> + <name>maven.test.skip</name> + <value>!true</value> + </property> + </activation> + <build> + <plugins> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-invoker-plugin</artifactId> + <version>1.2</version> + <configuration> + <projectsDirectory>src/it</projectsDirectory> + <pomIncludes> + <pomInclude>**/**/pom.xml</pomInclude> + </pomIncludes> + <postBuildHookScript>verify.bsh</postBuildHookScript> + <localRepositoryPath>${basedir}/target/local-repo</localRepositoryPath> + <goals> + <goal>clean</goal> + <goal>${project.groupId}:${project.artifactId}:${project.version}:site</goal> + </goals> + <settingsFile>src/it/settings.xml</settingsFile> + </configuration> + <executions> + <execution> + <id>integration-test</id> + <phase>integration-test</phase> + <goals> + <goal>install</goal> + <goal>run</goal> + </goals> + </execution> + </executions> + </plugin> + </plugins> + </build> + </profile> + </profiles> + <dependencies> <!-- Maven --> <dependency> @@ -286,70 +343,6 @@ </dependency> </dependencies> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-plugin-plugin</artifactId> - <version>2.4.2-SNAPSHOT</version> - </plugin> - <plugin> - <artifactId>maven-surefire-plugin</artifactId> - <version>2.3</version> - </plugin> - </plugins> - </build> - - <profiles> - <profile> - <id>integration-tests</id> - <activation> - <property> - <name>maven.test.skip</name> - <value>!true</value> - </property> - </activation> - <build> - <plugins> - <plugin> - <groupId>org.apache.maven.plugins</groupId> - <artifactId>maven-invoker-plugin</artifactId> - <version>1.2</version> - <configuration> - <projectsDirectory>src/it</projectsDirectory> - <pomIncludes> - <pomInclude>**/**/pom.xml</pomInclude> - </pomIncludes> - <postBuildHookScript>verify.bsh</postBuildHookScript> - <localRepositoryPath>${basedir}/target/local-repo</localRepositoryPath> - <goals> - <goal>clean</goal> - <goal>${project.groupId}:${project.artifactId}:${project.version}:site</goal> - </goals> - <settingsFile>src/it/settings.xml</settingsFile> - </configuration> - <executions> - <execution> - <id>integration-test</id> - <phase>integration-test</phase> - <goals> - <goal>install</goal> - <goal>run</goal> - </goals> - </execution> - </executions> - </plugin> - </plugins> - </build> - </profile> - </profiles> - - <properties> - <doxiaVersion>1.0-alpha-11</doxiaVersion> - <doxiaSitetoolsVersion>1.0-alpha-11</doxiaSitetoolsVersion> - <wagonVersion>1.0-beta-2</wagonVersion> - </properties> - <reporting> <plugins> <plugin> @@ -381,4 +374,10 @@ </plugin> </plugins> </reporting> + + <properties> + <doxiaVersion>1.0-alpha-11</doxiaVersion> + <doxiaSitetoolsVersion>1.0-alpha-11</doxiaSitetoolsVersion> + <wagonVersion>1.0-beta-2</wagonVersion> + </properties> </project> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
