----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17325/#review33244 -----------------------------------------------------------
Looks good! 3rdparty/libprocess/include/process/system.hpp <https://reviews.apache.org/r/17325/#comment62630> Did you need this? 3rdparty/libprocess/include/process/system.hpp <https://reviews.apache.org/r/17325/#comment62631> Did you need this? 3rdparty/libprocess/include/process/system.hpp <https://reviews.apache.org/r/17325/#comment62626> Some documentation here would be helpful for those looking at this header and trying to figure out how to use it. Hint: They probably don't want to use this explicitly but rather just know that this is available by default in libprocess. Two things we should leave for another time but I think are worth mentioning: 1. I'm not sure there's a reason to be exposing these (profiler.hpp, system.hpp) in 'include' but let's leave that for another time. 2. Since libprocess is not a header-only library, we should consider placing implementation in .cpp files to speed up compile times. 3rdparty/libprocess/src/process.cpp <https://reviews.apache.org/r/17325/#comment62629> End with a period. :) - Ben Mahler On Jan. 24, 2014, 7:31 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17325/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2014, 7:31 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-581 > https://issues.apache.org/jira/browse/MESOS-581 > > > Repository: mesos-git > > > Description > ------- > > Skipped #16631 and let this RR take over. > > This patch adds a /system HTTP handler to libprocess for node/system centric > metrics and tracing. > > The first metric exposed is average system load (usual uptime(1) style;1, 5 > and > 15 minutes averages) along with local cpu count. The fields are named > cpus_total, avg_load_XXmin. > > Further more, help text should explain fields in /system/stats.json > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 40f01a7 > 3rdparty/libprocess/include/process/system.hpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp bc7a1c5 > > Diff: https://reviews.apache.org/r/17325/diff/ > > > Testing > ------- > > make check and functional testing of end-point. > > > Thanks, > > Niklas Nielsen > >
