> On Feb. 3, 2014, 7:51 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/system.hpp, line 35 > > <https://reviews.apache.org/r/17325/diff/4/?file=457110#file457110line35> > > > > Consider a static function as used in Duration to move the help string > > to the header file.
(See Duration::min() and Duration::max(), we used static functions instead of static members to avoid the need for definitions in .cpp files) - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17325/#review33456 ----------------------------------------------------------- On Jan. 30, 2014, 11:46 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17325/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 11:46 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-581 > https://issues.apache.org/jira/browse/MESOS-581 > > > Repository: mesos-git > > > Description > ------- > > Skipped #16631 and let this RR take over. > > This patch adds a /system HTTP handler to libprocess for node/system centric > metrics and tracing. > > The first metric exposed is average system load (usual uptime(1) style;1, 5 > and > 15 minutes averages) along with local cpu count. The fields are named > cpus_total, avg_load_XXmin. > > Further more, help text should explain fields in /system/stats.json > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am bbd17cc > 3rdparty/libprocess/include/process/system.hpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp 1083a35 > > Diff: https://reviews.apache.org/r/17325/diff/ > > > Testing > ------- > > make check and functional testing of end-point. > > > Thanks, > > Niklas Nielsen > >
