-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17325/#review33529
-----------------------------------------------------------



3rdparty/libprocess/include/process/system.hpp
<https://reviews.apache.org/r/17325/#comment63042>

    This might get bitten by the same bug that is referenced in constants.hpp, 
statistics.hpp, timeseries.hpp in which the constants were not being 
initialized when compiled with gcc-4.1.2.
    
    Perhaps this is immune to the bug since it's a static _member_. This won't 
matter once we have C++11 required and can remove support for older compilers.
    
    In duration.hpp we made max, min static methods to avoid this issue.


- Ben Mahler


On Feb. 3, 2014, 10:10 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17325/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2014, 10:10 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-581
>     https://issues.apache.org/jira/browse/MESOS-581
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Skipped #16631 and let this RR take over. 
> 
> This patch adds a /system HTTP handler to libprocess for node/system centric 
> metrics and tracing.
> 
> The first metric exposed is average system load (usual uptime(1) style;1, 5 
> and
> 15 minutes averages) along with local cpu count. The fields are named
> cpus_total, avg_load_XXmin.
> 
> Further more, help text should explain fields in /system/stats.json
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am bbd17cc 
>   3rdparty/libprocess/include/process/system.hpp PRE-CREATION 
>   3rdparty/libprocess/src/process.cpp 1083a35 
> 
> Diff: https://reviews.apache.org/r/17325/diff/
> 
> 
> Testing
> -------
> 
> make check and functional testing of end-point.
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Reply via email to