> On Feb. 3, 2014, 3:34 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/system.hpp, lines 54-66 > > <https://reviews.apache.org/r/17325/diff/5/?file=463622#file463622line54> > > > > This might get bitten by the same bug that is referenced in > > constants.hpp, statistics.hpp, timeseries.hpp in which the constants were > > not being initialized when compiled with gcc-4.1.2. > > > > Perhaps this is immune to the bug since it's a static _member_. This > > won't matter once we have C++11 required and can remove support for older > > compilers. > > > > In duration.hpp we made max, min static methods to avoid this issue.
Yeah, I did think about the static keyword but that would AFAIK generate a compile error for a static member variable. Should we revert to having this in process.cpp instead? - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17325/#review33529 ----------------------------------------------------------- On Feb. 3, 2014, 2:10 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17325/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2014, 2:10 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. > > > Bugs: MESOS-581 > https://issues.apache.org/jira/browse/MESOS-581 > > > Repository: mesos-git > > > Description > ------- > > Skipped #16631 and let this RR take over. > > This patch adds a /system HTTP handler to libprocess for node/system centric > metrics and tracing. > > The first metric exposed is average system load (usual uptime(1) style;1, 5 > and > 15 minutes averages) along with local cpu count. The fields are named > cpus_total, avg_load_XXmin. > > Further more, help text should explain fields in /system/stats.json > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am bbd17cc > 3rdparty/libprocess/include/process/system.hpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp 1083a35 > > Diff: https://reviews.apache.org/r/17325/diff/ > > > Testing > ------- > > make check and functional testing of end-point. > > > Thanks, > > Niklas Nielsen > >
