----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review33919 -----------------------------------------------------------
Ship it! src/slave/containerizer/isolator.hpp <https://reviews.apache.org/r/16150/#comment63700> Please wrap everything at 80 columns! src/slave/containerizer/isolator.hpp <https://reviews.apache.org/r/16150/#comment63697> Can kill this newline. src/slave/containerizer/isolator.cpp <https://reviews.apache.org/r/16150/#comment63698> FYI, you can also do 'process::spawn(CHECK_NOTNULL(process.get()))'. src/slave/containerizer/isolator.cpp <https://reviews.apache.org/r/16150/#comment63699> Please wrap everything in here at 80 columns. src/slave/containerizer/isolators/posix.hpp <https://reviews.apache.org/r/16150/#comment63703> Wrap at 80 columns pretty pretty please! src/slave/containerizer/isolators/posix.hpp <https://reviews.apache.org/r/16150/#comment63701> The wrapping is usually: process::Owned<process::Promise<Limitation> > promise( new process::Promise<Limitation>()); src/slave/containerizer/isolators/posix.hpp <https://reviews.apache.org/r/16150/#comment63702> The wrapping is usually: process::Owned<process::Promise<Limitation> > promise( new process::Promise<Limitation>()); src/slave/containerizer/isolators/posix.hpp <https://reviews.apache.org/r/16150/#comment63704> You can kill the newline. - Benjamin Hindman On Feb. 7, 2014, 3:36 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16150/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2014, 3:36 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Isolators perform isolator for the MesosContainerizer > > Isolator interface and implementations of Posix CPU and Mem isolators (no > isolation, just usage()) > > > Diffs > ----- > > src/Makefile.am c30706846bca1fa3287291e39f46a23713ad1ba4 > src/slave/containerizer/isolator.hpp PRE-CREATION > src/slave/containerizer/isolator.cpp PRE-CREATION > src/slave/containerizer/isolators/posix.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16150/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
