----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review33022 -----------------------------------------------------------
src/slave/containerizer/isolator.hpp <https://reviews.apache.org/r/16150/#comment62168> const? src/slave/containerizer/isolator.hpp <https://reviews.apache.org/r/16150/#comment62169> const ? src/slave/containerizer/isolators/posix.hpp <https://reviews.apache.org/r/16150/#comment62174> I'm assuming you don't people to directly use PosixIsolatorProcess but rather its subclasses? If yes, should we make its constructor(s) private? src/slave/containerizer/isolators/posix.hpp <https://reviews.apache.org/r/16150/#comment62171> As mentioned in earlier reviews, this shouldn't be an error? src/slave/containerizer/isolators/posix.hpp <https://reviews.apache.org/r/16150/#comment62172> How is this possible? Comment? src/slave/containerizer/isolators/posix.hpp <https://reviews.apache.org/r/16150/#comment62182> What if the pid exits by this point? Should it be a Failure or return empty resource stats? src/slave/containerizer/isolators/posix.hpp <https://reviews.apache.org/r/16150/#comment62183> ditto. - Vinod Kone On Jan. 27, 2014, 3:02 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16150/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 3:02 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Isolators perform isolator for the MesosContainerizer > > Isolator interface and implementations of Posix CPU and Mem isolators (no > isolation, just usage()) > > > Diffs > ----- > > src/Makefile.am cf0c8c66e8dd21c2f5a2da22e5d5adb056353454 > src/slave/containerizer/isolator.hpp PRE-CREATION > src/slave/containerizer/isolator.cpp PRE-CREATION > src/slave/containerizer/isolators/posix.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16150/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
