> On Jan. 28, 2014, 7:42 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/posix.hpp, line 36 > > <https://reviews.apache.org/r/16150/diff/5/?file=451176#file451176line36> > > > > I'm assuming you don't people to directly use PosixIsolatorProcess but > > rather its subclasses? > > > > If yes, should we make its constructor(s) private?
It hasn't implemented Isolator::usage() so it's still abstract. Is that sufficient or should I make the constructor private too? > On Jan. 28, 2014, 7:42 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/posix.hpp, lines 52-54 > > <https://reviews.apache.org/r/16150/diff/5/?file=451176#file451176line52> > > > > As mentioned in earlier reviews, this shouldn't be an error? MesosContainerizer only tries to recover containers from the isolators and launchers if they have pids. > On Jan. 28, 2014, 7:42 p.m., Vinod Kone wrote: > > src/slave/containerizer/isolators/posix.hpp, line 140 > > <https://reviews.apache.org/r/16150/diff/5/?file=451176#file451176line140> > > > > What if the pid exits by this point? Should it be a Failure or return > > empty resource stats? Yes, should just return empty stats. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16150/#review33022 ----------------------------------------------------------- On Jan. 27, 2014, 3:02 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16150/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2014, 3:02 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Niklas > Nielsen, samya, and Jason Dusek. > > > Repository: mesos-git > > > Description > ------- > > Isolators perform isolator for the MesosContainerizer > > Isolator interface and implementations of Posix CPU and Mem isolators (no > isolation, just usage()) > > > Diffs > ----- > > src/Makefile.am cf0c8c66e8dd21c2f5a2da22e5d5adb056353454 > src/slave/containerizer/isolator.hpp PRE-CREATION > src/slave/containerizer/isolator.cpp PRE-CREATION > src/slave/containerizer/isolators/posix.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/16150/diff/ > > > Testing > ------- > > > Thanks, > > Ian Downes > >
