----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/#review34675 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/16724/#comment64893> Where does completedFramework clash (since the '_')? src/messages/messages.proto <https://reviews.apache.org/r/16724/#comment64894> Is this comment obsolete? src/slave/slave.cpp <https://reviews.apache.org/r/16724/#comment64892> Fix indentation :) src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/16724/#comment64891> Would you mind adding a period at the end of you test comments (for the entire test)? :) src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/16724/#comment64898> s/Json/JSON/? src/tests/fault_tolerance_tests.cpp <https://reviews.apache.org/r/16724/#comment64901> Can you scan this file and wrap at 80? src/tests/mesos.hpp <https://reviews.apache.org/r/16724/#comment64896> You only use helper once, so how about moving it to fault_tolerance_tests.cpp (like findJsonValue)? src/tests/mesos.hpp <https://reviews.apache.org/r/16724/#comment64903> Any need to MergeFrom? If not, then use CopyFrom :) - Niklas Nielsen On Feb. 17, 2014, 4:23 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16724/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2014, 4:23 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and > Vinod Kone. > > > Bugs: MESOS-767 > https://issues.apache.org/jira/browse/MESOS-767 > > > Repository: mesos-git > > > Description > ------- > > Added completed frameworks/tasks to slave re-registration. > Fixes MESOS-767. > > Additional issues discovered during investigation: > - MESOS-905: Remove Framework.id in favor of FrameworkInfo.id > - MESOS-906: Last task in Completed Framework never graduates from > terminatedTasks to completedTasks. > - Completed frameworks/executors/tasks are stored in circular buffers, > and these may overflow in different orders on different slaves. > BenH proposes an archive to replace these circular buffers. > > > Diffs > ----- > > include/mesos/scheduler.hpp 2e4707e > src/master/master.hpp 7649737 > src/master/master.cpp 77872ec > src/messages/messages.proto 922a8c4 > src/slave/slave.cpp 2d21e16 > src/tests/fault_tolerance_tests.cpp 60e06cc > src/tests/mesos.hpp d7bdaee > > Diff: https://reviews.apache.org/r/16724/diff/ > > > Testing > ------- > > make check; manually failed-over a master, watched the slave reregister its > completed frameworks, web UI shows completed tasks and stdout/stderr. > Added a new unit/integration test to verify the expected behavior. > > > Thanks, > > Adam B > >
