> On Jan. 29, 2014, 4:58 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 712 > > <https://reviews.apache.org/r/16724/diff/4/?file=454079#file454079line712> > > > > why the different log level? > > > > s/2/1/? > > Adam B wrote: > I figured that the different log levels could be used for different > verbosity levels, such that in this case VLOG(1) gives one statement per > framework, VLOG(2) gives one per executor, and VLOG(3) gives one statement > per task. Seeing that all of mesos only has 5 VLOG(2)'s and 1 VLOG(3), all in > sched.cpp, we're really not using VLOG levels much yet. > I'm happy to change these all over to VLOG(1) if desired, but I would > like to open up a dialogue about our debug/vlog log-level policy.
Changed the VLOG(3)'s to VLOG(2)'s, since they're more verbose than necessary for a VLOG(1), but could still be useful to someone debugging deep into this code. Seems like there's no real policy, so I'll just stick to two VLOG levels for now. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/#review33187 ----------------------------------------------------------- On Feb. 27, 2014, 12:28 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16724/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 12:28 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-767 > https://issues.apache.org/jira/browse/MESOS-767 > > > Repository: mesos-git > > > Description > ------- > > Added completed frameworks/tasks to slave re-registration. > Fixes MESOS-767. > > Additional issues discovered during investigation: > - MESOS-905: Remove Framework.id in favor of FrameworkInfo.id > - MESOS-906: Last task in Completed Framework never graduates from > terminatedTasks to completedTasks. > - Completed frameworks/executors/tasks are stored in circular buffers, > and these may overflow in different orders on different slaves. > BenH proposes an archive to replace these circular buffers. > > > Diffs > ----- > > include/mesos/scheduler.hpp 2e4707e > src/master/master.hpp 7649737 > src/master/master.cpp 77872ec > src/messages/messages.proto 922a8c4 > src/slave/slave.cpp 2d21e16 > src/tests/fault_tolerance_tests.cpp 60e06cc > src/tests/mesos.hpp d7bdaee > > Diff: https://reviews.apache.org/r/16724/diff/ > > > Testing > ------- > > make check; manually failed-over a master, watched the slave reregister its > completed frameworks, web UI shows completed tasks and stdout/stderr. > Added a new unit/integration test to verify the expected behavior. > > > Thanks, > > Adam B > >
