> On Jan. 29, 2014, 4:58 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 712 > > <https://reviews.apache.org/r/16724/diff/4/?file=454079#file454079line712> > > > > why the different log level? > > > > s/2/1/?
I figured that the different log levels could be used for different verbosity levels, such that in this case VLOG(1) gives one statement per framework, VLOG(2) gives one per executor, and VLOG(3) gives one statement per task. Seeing that all of mesos only has 5 VLOG(2)'s and 1 VLOG(3), all in sched.cpp, we're really not using VLOG levels much yet. I'm happy to change these all over to VLOG(1) if desired, but I would like to open up a dialogue about our debug/vlog log-level policy. > On Jan. 29, 2014, 4:58 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 144 > > <https://reviews.apache.org/r/16724/diff/4/?file=454076#file454076line144> > > > > we tend to not add "_" suffixes to params in declarations. Interesting. Seems a little weird to me to have the declaration without '_' and the implementation with it, but it does make the header look cleaner. Fixed. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/#review33187 ----------------------------------------------------------- On Jan. 29, 2014, 4:17 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16724/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2014, 4:17 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and > Vinod Kone. > > > Bugs: MESOS-767 > https://issues.apache.org/jira/browse/MESOS-767 > > > Repository: mesos-git > > > Description > ------- > > Added completed frameworks/tasks to slave re-registration. > Fixes MESOS-767. > > Additional issues discovered during investigation: > - MESOS-905: Remove Framework.id in favor of FrameworkInfo.id > - MESOS-906: Last task in Completed Framework never graduates from > terminatedTasks to completedTasks. > - Completed frameworks/executors/tasks are stored in circular buffers, > and these may overflow in different orders on different slaves. > BenH proposes an archive to replace these circular buffers. > > > Diffs > ----- > > src/master/master.hpp 7649737 > src/master/master.cpp 77872ec > src/messages/messages.proto 922a8c4 > src/slave/slave.cpp 2d21e16 > > Diff: https://reviews.apache.org/r/16724/diff/ > > > Testing > ------- > > make check; manually failed-over a master, watched the slave reregister its > completed frameworks, web UI shows completed tasks and stdout/stderr. > > > Thanks, > > Adam B > >
