> On Jan. 27, 2014, 10:44 p.m., Vinod Kone wrote: > > Can we add a test for this please?
Certainly. I'll jump on that this week. Thanks for reviewing! > On Jan. 27, 2014, 10:44 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1367 > > <https://reviews.apache.org/r/16724/diff/3/?file=425217#file425217line1367> > > > > s/slaveCompletedFrameworks/completedFrameworks/ 'completedFrameworks' is already a member variable of Master. How about 'completedFrameworks_'? > On Jan. 27, 2014, 10:44 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 2748 > > <https://reviews.apache.org/r/16724/diff/3/?file=425217#file425217line2748> > > > > new line. Comment removed after making time optional to Framework(). No further need for a newline. > On Jan. 27, 2014, 10:44 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 725-728 > > <https://reviews.apache.org/r/16724/diff/3/?file=425219#file425219line725> > > > > I think you've brought this up before but did you figure out why a > > completed executor has terminated tasks? Not exactly, not yet. I'll look into this as I'm writing and running tests. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16724/#review32961 ----------------------------------------------------------- On Jan. 16, 2014, 4:24 p.m., Adam B wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16724/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 4:24 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Niklas Nielsen, and > Vinod Kone. > > > Bugs: MESOS-767 > https://issues.apache.org/jira/browse/MESOS-767 > > > Repository: mesos-git > > > Description > ------- > > Added completed frameworks/tasks to slave re-registration. > Fixes MESOS-767. > > Additional issues discovered during investigation: > - MESOS-905: Remove Framework.id in favor of FrameworkInfo.id > - MESOS-906: Last task in Completed Framework never graduates from > terminatedTasks to completedTasks. > - Completed frameworks/executors/tasks are stored in circular buffers, > and these may overflow in different orders on different slaves. > BenH proposes an archive to replace these circular buffers. > > > Diffs > ----- > > src/master/master.hpp 95b9cec > src/master/master.cpp 38c5532 > src/messages/messages.proto 1f264d5 > src/slave/slave.cpp 396293b > > Diff: https://reviews.apache.org/r/16724/diff/ > > > Testing > ------- > > make check; manually failed-over a master, watched the slave reregister its > completed frameworks, web UI shows completed tasks and stdout/stderr. > > > Thanks, > > Adam B > >
