----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/ -----------------------------------------------------------
Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Repository: mesos-git Description ------- We *may* have observed deadlocks in the forked child when testing some other new code so this makes the execute() function in MesosContainerizer completely async-signal safe. Reviewers: I'd appreciate it if you could carefully check that I've made this completely async signal safe. Replace all stout calls with just the appropriate system call. Construct Envp and pass into child and use execle for the environment. Use open and dup2 rather than freopen. Determine gid and uid and pass into child. Diffs ----- src/slave/containerizer/mesos_containerizer.cpp df57e5443d0e3a94588464d83822ed5e3e9f88ea Diff: https://reviews.apache.org/r/20958/diff/ Testing ------- make check Thanks, Ian Downes
