----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/#review43231 -----------------------------------------------------------
In general, I'd love to see us actually print out either the errno value, or even better the errno string upon an ABORT() or other failure caused by a syscall. It makes tracking down issues much easier. src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment77314> While this may work, there is no POSIX reason that you could not get a short read here... src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment77315> Why not add perror() or at least the errno to this output? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment77316> Ditto src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment77318> Print error as to why? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment77319> Ditto - Tobias Weingartner On May 1, 2014, 5:26 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20958/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 5:26 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > We *may* have observed deadlocks in the forked child when testing some other > new code so this makes the execute() function in MesosContainerizer > completely async-signal safe. > > Reviewers: I'd appreciate it if you could carefully check that I've made this > completely async signal safe. > > > Replace all stout calls with just the appropriate system call. > > Construct Envp and pass into child and use execle for the environment. > > Use open and dup2 rather than freopen. > > Determine gid and uid and pass into child. > > > Diffs > ----- > > src/slave/containerizer/mesos_containerizer.cpp > df57e5443d0e3a94588464d83822ed5e3e9f88ea > > Diff: https://reviews.apache.org/r/20958/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
