> On May 6, 2014, 10:56 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos_containerizer.cpp, lines 544-551 > > <https://reviews.apache.org/r/20958/diff/1/?file=572684#file572684line544> > > > > This is now part of 'fetch', but it has nothing to do with 'fetch'. How > > about pulling it to a top level method and modify the chain in '_launch'?
I think it's natural to include it as the final part of fetch. I don't want to pull all pieces up to the chain at _launch so I'm going to leave it where it is. Feel free to object :-) - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/#review42301 ----------------------------------------------------------- On May 1, 2014, 10:26 a.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20958/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 10:26 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > We *may* have observed deadlocks in the forked child when testing some other > new code so this makes the execute() function in MesosContainerizer > completely async-signal safe. > > Reviewers: I'd appreciate it if you could carefully check that I've made this > completely async signal safe. > > > Replace all stout calls with just the appropriate system call. > > Construct Envp and pass into child and use execle for the environment. > > Use open and dup2 rather than freopen. > > Determine gid and uid and pass into child. > > > Diffs > ----- > > src/slave/containerizer/mesos_containerizer.cpp > df57e5443d0e3a94588464d83822ed5e3e9f88ea > > Diff: https://reviews.apache.org/r/20958/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
