----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20958/#review42301 -----------------------------------------------------------
src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment76080> "Failed to open stdout"? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment76090> dup2 of what failed? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment76092> For the sake of consistency, do you need to check the return value of 'close' here? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment76081> "Failed to open stderr"? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment76091> ditto src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment76077> This is now part of 'fetch', but it has nothing to do with 'fetch'. How about pulling it to a top level method and modify the chain in '_launch'? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment76076> Why ABORT here? Shouldn't just return Failure("..")? src/slave/containerizer/mesos_containerizer.cpp <https://reviews.apache.org/r/20958/#comment76078> Can we make os::getuid accept an optional user name? In that way, here you can just do: Try<uid_t> uid = os::getuid(user); .... - Jie Yu On May 1, 2014, 5:26 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/20958/ > ----------------------------------------------------------- > > (Updated May 1, 2014, 5:26 p.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > We *may* have observed deadlocks in the forked child when testing some other > new code so this makes the execute() function in MesosContainerizer > completely async-signal safe. > > Reviewers: I'd appreciate it if you could carefully check that I've made this > completely async signal safe. > > > Replace all stout calls with just the appropriate system call. > > Construct Envp and pass into child and use execle for the environment. > > Use open and dup2 rather than freopen. > > Determine gid and uid and pass into child. > > > Diffs > ----- > > src/slave/containerizer/mesos_containerizer.cpp > df57e5443d0e3a94588464d83822ed5e3e9f88ea > > Diff: https://reviews.apache.org/r/20958/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ian Downes > >
