----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21443/#review43141 -----------------------------------------------------------
src/linux/perf.hpp <https://reviews.apache.org/r/21443/#comment77156> 2 lines between declarations. src/linux/perf.cpp <https://reviews.apache.org/r/21443/#comment77160> end with period. src/linux/perf.cpp <https://reviews.apache.org/r/21443/#comment77161> If it wraps within 80, you should do Try<double> number = (value == ...................... src/linux/perf.cpp <https://reviews.apache.org/r/21443/#comment77162> Doesn't look like this is being used anywhere? Kill it. src/linux/perf.cpp <https://reviews.apache.org/r/21443/#comment77163> Kill the else. Just do if (parse.isErorr()) { ... return; } ... ... src/tests/cgroups_tests.cpp <https://reviews.apache.org/r/21443/#comment77164> end with period. src/tests/isolator_tests.cpp <https://reviews.apache.org/r/21443/#comment77165> Hmm..Does this belong to this review? - Vinod Kone On May 14, 2014, 10:05 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21443/ > ----------------------------------------------------------- > > (Updated May 14, 2014, 10:05 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1278 > https://issues.apache.org/jira/browse/MESOS-1278 > > > Repository: mesos-git > > > Description > ------- > > Perf can be run against either a set of pids or a perf_event cgroup. > > I decided to parse the perf output into the protobuf directly, rather than > via JSON, because it was simpler to handle output like <not supported> and > <not counted>. Plus JSON's floating point numbers cannot fully represent > uint64. > > > Diffs > ----- > > src/Makefile.am 12374c4a87836c160a7050c37ff7fec544b724e1 > src/linux/perf.hpp PRE-CREATION > src/linux/perf.cpp PRE-CREATION > src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753 > src/tests/isolator_tests.cpp b0eff5721b6ea4dcee8ff3748a2a11ade809e30e > src/tests/perf_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21443/diff/ > > > Testing > ------- > > Added tests for pids and cgroups. > > > Thanks, > > Ian Downes > >
