----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21443/#review44951 -----------------------------------------------------------
src/linux/perf.hpp <https://reviews.apache.org/r/21443/#comment79534> s/Expose/NOTE: Exposed/ src/linux/perf.cpp <https://reviews.apache.org/r/21443/#comment79540> s/,/;/ src/linux/perf.cpp <https://reviews.apache.org/r/21443/#comment79541> s/use ""/use "" as key/ ? also, i don't understand the semantics of ""? why is this not an Option? src/linux/perf.cpp <https://reviews.apache.org/r/21443/#comment79539> Taking a future as an argument here seems weird. Why not take the hashmap directly? AFAICT, this is called with a .then(). src/linux/perf.cpp <https://reviews.apache.org/r/21443/#comment79542> can this be pid or stringify(pids) instead of "" ? - Vinod Kone On June 3, 2014, 8:45 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21443/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 8:45 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1278 > https://issues.apache.org/jira/browse/MESOS-1278 > > > Repository: mesos-git > > > Description > ------- > > Perf can be run against either a set of pids or a perf_event cgroup. > > I decided to parse the perf output into the protobuf directly, rather than > via JSON, because it was simpler to handle output like <not supported> and > <not counted>. Plus JSON's floating point numbers cannot fully represent > uint64. > > > Diffs > ----- > > src/Makefile.am ffde59be8683dd40cc5bc7cb88cd88c5bc91cf96 > src/linux/perf.hpp PRE-CREATION > src/linux/perf.cpp PRE-CREATION > src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753 > src/tests/perf_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21443/diff/ > > > Testing > ------- > > Added tests for pids and cgroups. > > > Thanks, > > Ian Downes > >
