> On May 30, 2014, 12:35 p.m., Ben Mahler wrote: > > src/linux/perf.hpp, lines 72-74 > > <https://reviews.apache.org/r/21443/diff/4/?file=599352#file599352line72> > > > > Should we put this in an 'internal' namespace to at least make it > > harder to get at for callers? > > > > Let's document what it returns, that is, what are the keys?
Originally it was but I pulled it out to expose for testing. Is there a nicer way to keep it accessible for testing but otherwise inaccessible? - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21443/#review44409 ----------------------------------------------------------- On June 3, 2014, 1:45 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21443/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 1:45 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-1278 > https://issues.apache.org/jira/browse/MESOS-1278 > > > Repository: mesos-git > > > Description > ------- > > Perf can be run against either a set of pids or a perf_event cgroup. > > I decided to parse the perf output into the protobuf directly, rather than > via JSON, because it was simpler to handle output like <not supported> and > <not counted>. Plus JSON's floating point numbers cannot fully represent > uint64. > > > Diffs > ----- > > src/Makefile.am ffde59be8683dd40cc5bc7cb88cd88c5bc91cf96 > src/linux/perf.hpp PRE-CREATION > src/linux/perf.cpp PRE-CREATION > src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753 > src/tests/perf_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21443/diff/ > > > Testing > ------- > > Added tests for pids and cgroups. > > > Thanks, > > Ian Downes > >
