> On May 15, 2014, 12:21 p.m., Vinod Kone wrote: > > src/linux/perf.cpp, line 232 > > <https://reviews.apache.org/r/21443/diff/2/?file=581929#file581929line232> > > > > Doesn't look like this is being used anywhere? Kill it.
We should still read from stderr to avoid potential to block the process on the pipe but changed to not store the future. - Ian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21443/#review43141 ----------------------------------------------------------- On May 29, 2014, 2:25 p.m., Ian Downes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21443/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 2:25 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-1278 > https://issues.apache.org/jira/browse/MESOS-1278 > > > Repository: mesos-git > > > Description > ------- > > Perf can be run against either a set of pids or a perf_event cgroup. > > I decided to parse the perf output into the protobuf directly, rather than > via JSON, because it was simpler to handle output like <not supported> and > <not counted>. Plus JSON's floating point numbers cannot fully represent > uint64. > > > Diffs > ----- > > src/Makefile.am ffde59be8683dd40cc5bc7cb88cd88c5bc91cf96 > src/linux/perf.hpp PRE-CREATION > src/linux/perf.cpp PRE-CREATION > src/tests/cgroups_tests.cpp 5f674cd678e67f10bfef4620d927bb5af7c93753 > src/tests/perf_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21443/diff/ > > > Testing > ------- > > Added tests for pids and cgroups. > > > Thanks, > > Ian Downes > >
