----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21799/#review44370 -----------------------------------------------------------
src/linux/cgroups.cpp <https://reviews.apache.org/r/21799/#comment78726> Could you please add a third (and optional) argument to this function: Try<Nothing> create( const string& hierarchy, const string& cgroup, bool recursive = false); And then modify 'prepare' below to deal with nested cgroups_root problem? src/linux/cgroups.cpp <https://reviews.apache.org/r/21799/#comment78728> Hum, what if the user specify '--slave_subsystems=cpu,cpuacct' on the command line? IIUC, the 'prepare' function will be called twice: one for 'cpu' and one for 'cpuacct', and one of them will fail? src/linux/cgroups.cpp <https://reviews.apache.org/r/21799/#comment78727> To deal with nested cgroups_root: // No cgroup exist, create it (recursively). Try<Nothing> create = cgroups::create(hierarchy, cgroup, true); - Jie Yu On May 29, 2014, 2:01 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21799/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 2:01 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Bugs: MESOS-1195 > https://issues.apache.org/jira/browse/MESOS-1195 > > > Repository: mesos-git > > > Description > ------- > > Fixes to enable cgroups to function when initialized via systemd defaults: > + Fix for co-mounting cpu,cpuacct > + Fix for nested cgroups_root='system.slice/mesos-slave.service' > + Diagnostics to propagate error details. > > > Diffs > ----- > > src/linux/cgroups.cpp 142ac43 > src/slave/containerizer/isolators/cgroups/mem.cpp 6324dcd > > Diff: https://reviews.apache.org/r/21799/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >