> On May 30, 2014, 4:17 p.m., Jie Yu wrote: > > src/linux/cgroups.cpp, lines 454-463 > > <https://reviews.apache.org/r/21799/diff/1/?file=587746#file587746line454> > > > > Hum, what if the user specify '--slave_subsystems=cpu,cpuacct' on the > > command line? IIUC, the 'prepare' function will be called twice: one for > > 'cpu' and one for 'cpuacct', and one of them will fail?
Right now they already mounted by systemd, and the logic here check to see if they are co-mounted. This simply adds the exception to allow the case when: export MESOS_isolation='cgroups/cpu,cgroups/mem' export MESOS_hierarchy=/sys/fs/cgroup I don't think we want mesos to do the co-mounting explicitly... > On May 30, 2014, 4:17 p.m., Jie Yu wrote: > > src/linux/cgroups.cpp, line 282 > > <https://reviews.apache.org/r/21799/diff/1/?file=587746#file587746line282> > > > > Could you please add a third (and optional) argument to this function: > > > > Try<Nothing> create( > > const string& hierarchy, > > const string& cgroup, > > bool recursive = false); > > > > And then modify 'prepare' below to deal with nested cgroups_root > > problem? sure thing, I'll update the patch - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21799/#review44370 ----------------------------------------------------------- On May 29, 2014, 2:01 p.m., Timothy St. Clair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21799/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 2:01 p.m.) > > > Review request for mesos, Benjamin Hindman, Ian Downes, and Jie Yu. > > > Bugs: MESOS-1195 > https://issues.apache.org/jira/browse/MESOS-1195 > > > Repository: mesos-git > > > Description > ------- > > Fixes to enable cgroups to function when initialized via systemd defaults: > + Fix for co-mounting cpu,cpuacct > + Fix for nested cgroups_root='system.slice/mesos-slave.service' > + Diagnostics to propagate error details. > > > Diffs > ----- > > src/linux/cgroups.cpp 142ac43 > src/slave/containerizer/isolators/cgroups/mem.cpp 6324dcd > > Diff: https://reviews.apache.org/r/21799/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy St. Clair > >
