----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review44965 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/22316/#comment79571> See below for more on this, but the use of weak_ptr here and shared_ptr below hints at confused ownership semantics. There should be a single owner for a Counter and other sources of information should be directed to that owner. src/master/master.cpp <https://reviews.apache.org/r/22316/#comment79574> Consider commenting here about the case when we receive something from an inactive framework/PID. src/master/master.cpp <https://reviews.apache.org/r/22316/#comment79575> ownership is very confusing here. In the first stanza you set the metrics.framework_messages entry to reference the frameworks.messageCounters Counter. In the second stanza, the frameworks.messageCounters entry references the metrics.framework_messages Counter. Instead, consider having a mapping from PID to principal, and a mapping from principal to counter. src/master/master.cpp <https://reviews.apache.org/r/22316/#comment79577> consider checking the return of add src/master/master.cpp <https://reviews.apache.org/r/22316/#comment79576> consider checking the return of remove - Dominic Hamon On June 6, 2014, 1:17 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22316/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 1:17 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1339 > https://issues.apache.org/jira/browse/MESOS-1339 > > > Repository: mesos-git > > > Description > ------- > > - Multiple frameworks use the same principal use the same counter. > - The design is shared by rate limiters > - For more on the design see > https://cwiki.apache.org/confluence/display/MESOS/Framework+API+Rate+Limiting+Design+Document#FrameworkAPIRateLimitingDesignDocument-RateLimitinginMaster > which I am updating right now. > > > Diffs > ----- > > src/master/master.hpp e2448310aa714b5fae49b9bf4fc95859ae9d7ec3 > src/master/master.cpp 89f426c14de365369b900864f1983b1f9260953f > src/tests/fault_tolerance_tests.cpp > 4c6a5c4ecd42a5d0bb4b4d69ab2cd38f842edf7a > src/tests/master_tests.cpp 34df12195d7bbdf77fb6079aa3ad644264b8cfa5 > > Diff: https://reviews.apache.org/r/22316/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
