----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review44994 -----------------------------------------------------------
This patch is implicitly designed on the fact that rate limiting is what motivates this. In that, if we were to implement the counters on their own, we could just have a single map<principal, Counter> and count in each message handler. Since the complexity here arises from rate limiting, I would suggest we either: (1) Implement the limiting first (solve the issues being discussed in this review) (2) Or we should do the counting first, ignoring the fact that rate limiting is coming soon. This means a much simpler patch here and then circling back to update the counters. Up to you Yan! - Ben Mahler On June 6, 2014, 8:17 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22316/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 8:17 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1339 > https://issues.apache.org/jira/browse/MESOS-1339 > > > Repository: mesos-git > > > Description > ------- > > - Multiple frameworks use the same principal use the same counter. > - The design is shared by rate limiters > - For more on the design see > https://cwiki.apache.org/confluence/display/MESOS/Framework+API+Rate+Limiting+Design+Document#FrameworkAPIRateLimitingDesignDocument-RateLimitinginMaster > which I am updating right now. > > > Diffs > ----- > > src/master/master.hpp e2448310aa714b5fae49b9bf4fc95859ae9d7ec3 > src/master/master.cpp 89f426c14de365369b900864f1983b1f9260953f > src/tests/fault_tolerance_tests.cpp > 4c6a5c4ecd42a5d0bb4b4d69ab2cd38f842edf7a > src/tests/master_tests.cpp 34df12195d7bbdf77fb6079aa3ad644264b8cfa5 > > Diff: https://reviews.apache.org/r/22316/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
