----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22316/#review45034 -----------------------------------------------------------
Patch looks great! Reviews applied: [22250, 22316] All tests passed. - Mesos ReviewBot On June 6, 2014, 8:17 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22316/ > ----------------------------------------------------------- > > (Updated June 6, 2014, 8:17 p.m.) > > > Review request for mesos, Ben Mahler, Dominic Hamon, and Vinod Kone. > > > Bugs: MESOS-1339 > https://issues.apache.org/jira/browse/MESOS-1339 > > > Repository: mesos-git > > > Description > ------- > > - Multiple frameworks use the same principal use the same counter. > - The design is shared by rate limiters > - For more on the design see > https://cwiki.apache.org/confluence/display/MESOS/Framework+API+Rate+Limiting+Design+Document#FrameworkAPIRateLimitingDesignDocument-RateLimitinginMaster > which I am updating right now. > > > Diffs > ----- > > src/master/master.hpp e2448310aa714b5fae49b9bf4fc95859ae9d7ec3 > src/master/master.cpp 89f426c14de365369b900864f1983b1f9260953f > src/tests/fault_tolerance_tests.cpp > 4c6a5c4ecd42a5d0bb4b4d69ab2cd38f842edf7a > src/tests/master_tests.cpp 34df12195d7bbdf77fb6079aa3ad644264b8cfa5 > > Diff: https://reviews.apache.org/r/22316/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jiang Yan Xu > >
