> On June 27, 2014, 11:27 p.m., Dominic Hamon wrote: > > src/launcher/fetcher.cpp, line 34 > > <https://reviews.apache.org/r/21734/diff/12/?file=619949#file619949line34> > > > > const char FILE_URI_PREFIX[] = "file://"; > > > >
I actually prefer it to be string as it's being used in string functions that takes string type, so boxing is needed. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review46923 ----------------------------------------------------------- On June 27, 2014, 11:24 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21734/ > ----------------------------------------------------------- > > (Updated June 27, 2014, 11:24 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-390 > https://issues.apache.org/jira/browse/MESOS-390 > > > Repository: mesos-git > > > Description > ------- > > Handling file:// in the fetcher, and also handle case when localhost is used. > > > Diffs > ----- > > src/Makefile.am 9027927 > src/launcher/fetcher.cpp c4425eb > src/tests/fetcher_tests.cpp PRE-CREATION > src/tests/utils.hpp 5c86fd4 > > Diff: https://reviews.apache.org/r/21734/diff/ > > > Testing > ------- > > Added unit tests to test file:// and file://localhost. > make check. > > > Thanks, > > Timothy Chen > >
