> On June 20, 2014, 1:44 p.m., Ian Downes wrote:
> > src/tests/fetcher_tests.cpp, line 58
> > <https://reviews.apache.org/r/21734/diff/11/?file=611378#file611378line58>
> >
> > Drop this method and use the sandbox directory as created by
> > TemporaryDirectoryTest.
> >
> > You'll need to repeat a few lines of code for each test but it'll be
> > cleaner and easier to follow.
>
> Timothy Chen wrote:
> I was actually thinking to create the file on another directory and
> verify that the file is fetched into the current working directory, so if I
> use sandbox for both then the file already exists. Thoughts?
What about having {sandbox}/from/file and verifying the file gets copied to
{sandbox}/to/?
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21734/#review46313
-----------------------------------------------------------
On June 16, 2014, 9:47 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21734/
> -----------------------------------------------------------
>
> (Updated June 16, 2014, 9:47 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-390
> https://issues.apache.org/jira/browse/MESOS-390
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Handling file:// in the fetcher, and also handle case when localhost is used.
>
>
> Diffs
> -----
>
> src/Makefile.am 3e623cc
> src/launcher/fetcher.cpp c4425eb
> src/tests/fetcher_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21734/diff/
>
>
> Testing
> -------
>
> Added unit tests to test file:// and file://localhost.
> make check.
>
>
> Thanks,
>
> Timothy Chen
>
>
