> On June 20, 2014, 8:44 p.m., Ian Downes wrote: > > src/tests/fetcher_tests.cpp, line 73 > > <https://reviews.apache.org/r/21734/diff/11/?file=611378#file611378line73> > > > > use sandbox directory.
local file is where the file should end up being fetched to, so I wanted to use getcwd. > On June 20, 2014, 8:44 p.m., Ian Downes wrote: > > src/tests/fetcher_tests.cpp, line 79 > > <https://reviews.apache.org/r/21734/diff/11/?file=611378#file611378line79> > > > > aren't you using mesos::internal::tests? I got a compile error complaining that is it ambigious, so had to add a namespace to differentiate. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review46313 ----------------------------------------------------------- On June 17, 2014, 4:47 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21734/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 4:47 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-390 > https://issues.apache.org/jira/browse/MESOS-390 > > > Repository: mesos-git > > > Description > ------- > > Handling file:// in the fetcher, and also handle case when localhost is used. > > > Diffs > ----- > > src/Makefile.am 3e623cc > src/launcher/fetcher.cpp c4425eb > src/tests/fetcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21734/diff/ > > > Testing > ------- > > Added unit tests to test file:// and file://localhost. > make check. > > > Thanks, > > Timothy Chen > >
