----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21734/#review46726 -----------------------------------------------------------
Looks pretty good to me, but I imagine you'll have another revision coming after addressing Ian's feedback. I'll be ready to put my ShipIt stamp on it then. :) src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/21734/#comment82283> alphabetize src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/21734/#comment82284> A little more context would prevent this from looking like useless spam. src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/21734/#comment82285> Or do 'using mesos::internal::tests::flags'? src/tests/fetcher_tests.cpp <https://reviews.apache.org/r/21734/#comment82286> What removes localFile at the end? Is cwd inside the sandbox that gets deleted on TearDown? - Adam B On June 16, 2014, 9:47 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/21734/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 9:47 p.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-390 > https://issues.apache.org/jira/browse/MESOS-390 > > > Repository: mesos-git > > > Description > ------- > > Handling file:// in the fetcher, and also handle case when localhost is used. > > > Diffs > ----- > > src/Makefile.am 3e623cc > src/launcher/fetcher.cpp c4425eb > src/tests/fetcher_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/21734/diff/ > > > Testing > ------- > > Added unit tests to test file:// and file://localhost. > make check. > > > Thanks, > > Timothy Chen > >
