----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review52750 -----------------------------------------------------------
Great seeing new folks submitting reviews! Just a drive by here, Niklas will still shepherd this (unless I'm mistaken and you have a arranged with a different shepherd). src/exec/exec.cpp <https://reviews.apache.org/r/25434/#comment91748> Great to see a comment giving the _what_, but I'm left wondering the _why_? Why are you making the timeout shorter than the slave one? Even if it's obvious to you this is something that would be great to leave for posterity! src/launcher/executor.cpp <https://reviews.apache.org/r/25434/#comment91749> Minor style nit, please move all these indents to +4 on a newline after 'CommandExecutorProcess('. Same with the 'CommandExecutor' constructor below. Thanks Alex! src/launcher/executor.cpp <https://reviews.apache.org/r/25434/#comment91751> As long as you're editing up here, let's clean this up with s/string/const string&/ please, thanks! src/launcher/executor.cpp <https://reviews.apache.org/r/25434/#comment91753> Please move 'override' to newline too, thanks! src/launcher/executor.cpp <https://reviews.apache.org/r/25434/#comment91754> I'd rather not introduce namespace aliases, can we not put all of this in mesos::internal? src/launcher/executor.cpp <https://reviews.apache.org/r/25434/#comment91755> Why not call it 'value' like we do in the code above? src/slave/constants.hpp <https://reviews.apache.org/r/25434/#comment91771> What is the 'base executor' versus the 'command executor'? - Benjamin Hindman On Sept. 9, 2014, 12:54 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25434/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 12:54 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy St. > Clair. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > The configurable slave's executor_shutdown_grace_period flag is propagated to > Executor and CommandExecutor through an environment variable. Shutdown > timeout in Executor and signal escalation timeout in CommandExecutor are now > dependent on this flag. Each nested timeout is somewhat shorter than the > parent one. > > > Diffs > ----- > > src/exec/exec.cpp 36d1778 > src/launcher/executor.cpp 12ac14b > src/slave/constants.hpp 9030871 > src/slave/constants.cpp e1da5c0 > src/slave/containerizer/containerizer.hpp 8a66412 > src/slave/containerizer/containerizer.cpp 0254679 > src/slave/containerizer/docker.cpp 0febbac > src/slave/containerizer/external_containerizer.cpp efbc68f > src/slave/containerizer/mesos/containerizer.cpp 9d08329 > src/slave/flags.hpp 21e0021 > src/tests/containerizer.cpp a17e1e0 > > Diff: https://reviews.apache.org/r/25434/diff/ > > > Testing > ------- > > make check (OS X 10.9.4; Ubuntu 14.04 amd64) > > > Thanks, > > Alexander Rukletsov > >
