> On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: > > src/launcher/executor.cpp, lines 654-656 > > <https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line654> > > > > I'd rather not introduce namespace aliases, can we not put all of this > > in mesos::internal? > > Alexander Rukletsov wrote: > Looks like "namespace alias"-pro are in minority! Ok, I'll remove them > here and start a JIRA ticket to update the C++ style guide. > > Benjamin Hindman wrote: > So stoked to hear you're also going to update the style guide. Really > appreciate following through on that.
[Done](https://issues.apache.org/jira/browse/MESOS-1793). - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review52750 ----------------------------------------------------------- On Sept. 18, 2014, 11:03 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25434/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 11:03 a.m.) > > > Review request for mesos, Benjamin Hindman, Niklas Nielsen, Till Toenshoff, > and Timothy St. Clair. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > The configurable slave's executor_shutdown_grace_period flag is propagated to > Executor and CommandExecutor through an environment variable. Shutdown > timeout in Executor and signal escalation timeout in CommandExecutor are now > dependent on this flag. Each nested timeout is somewhat shorter than the > parent one. > > > Diffs > ----- > > src/Makefile.am 9b973e5 > src/exec/exec.cpp e15f834 > src/launcher/executor.cpp cbc8750 > src/slave/constants.hpp 9030871 > src/slave/constants.cpp e1da5c0 > src/slave/containerizer/containerizer.hpp 8a66412 > src/slave/containerizer/containerizer.cpp 0254679 > src/slave/containerizer/docker.cpp 0febbac > src/slave/containerizer/external_containerizer.cpp efbc68f > src/slave/containerizer/mesos/containerizer.cpp 9d08329 > src/slave/flags.hpp 21e0021 > src/slave/utils.hpp PRE-CREATION > src/slave/utils.cpp PRE-CREATION > src/tests/containerizer.cpp a17e1e0 > > Diff: https://reviews.apache.org/r/25434/diff/ > > > Testing > ------- > > make check (OS X 10.9.4) > > > Thanks, > > Alexander Rukletsov > >
