> On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: > > src/slave/constants.hpp, line 53 > > <https://reviews.apache.org/r/25434/diff/2/?file=683947#file683947line53> > > > > What is the 'base executor' versus the 'command executor'?
We have Executor (lives in src/exec/exec.cpp) and CommandExecutor aka mesos-executor (lives in src/launcher/executor.cpp). I find "executor" too vague and use "base executor" to stress out I mean the one that lives in exec.cpp. Is there a convention about naming these folks? > On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: > > src/exec/exec.cpp, lines 732-734 > > <https://reviews.apache.org/r/25434/diff/2/?file=683945#file683945line732> > > > > Great to see a comment giving the _what_, but I'm left wondering the > > _why_? Why are you making the timeout shorter than the slave one? Even if > > it's obvious to you this is something that would be great to leave for > > posterity! Agree, I will give more background here. > On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: > > src/launcher/executor.cpp, line 76 > > <https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line76> > > > > Minor style nit, please move all these indents to +4 on a newline after > > 'CommandExecutorProcess('. Same with the 'CommandExecutor' constructor > > below. Thanks Alex! Ok. > On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: > > src/launcher/executor.cpp, line 510 > > <https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line510> > > > > As long as you're editing up here, let's clean this up with > > s/string/const string&/ please, thanks! Ok. > On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: > > src/launcher/executor.cpp, line 513 > > <https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line513> > > > > Please move 'override' to newline too, thanks! Ok. > On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: > > src/launcher/executor.cpp, lines 654-656 > > <https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line654> > > > > I'd rather not introduce namespace aliases, can we not put all of this > > in mesos::internal? Looks like "namespace alias"-pro are in minority! Ok, I'll remove them here and start a JIRA ticket to update the C++ style guide. > On Sept. 9, 2014, 5:50 p.m., Benjamin Hindman wrote: > > src/launcher/executor.cpp, line 664 > > <https://reviews.apache.org/r/25434/diff/2/?file=683946#file683946line664> > > > > Why not call it 'value' like we do in the code above? Sure. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review52750 ----------------------------------------------------------- On Sept. 9, 2014, 12:54 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25434/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 12:54 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy St. > Clair. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > The configurable slave's executor_shutdown_grace_period flag is propagated to > Executor and CommandExecutor through an environment variable. Shutdown > timeout in Executor and signal escalation timeout in CommandExecutor are now > dependent on this flag. Each nested timeout is somewhat shorter than the > parent one. > > > Diffs > ----- > > src/exec/exec.cpp 36d1778 > src/launcher/executor.cpp 12ac14b > src/slave/constants.hpp 9030871 > src/slave/constants.cpp e1da5c0 > src/slave/containerizer/containerizer.hpp 8a66412 > src/slave/containerizer/containerizer.cpp 0254679 > src/slave/containerizer/docker.cpp 0febbac > src/slave/containerizer/external_containerizer.cpp efbc68f > src/slave/containerizer/mesos/containerizer.cpp 9d08329 > src/slave/flags.hpp 21e0021 > src/tests/containerizer.cpp a17e1e0 > > Diff: https://reviews.apache.org/r/25434/diff/ > > > Testing > ------- > > make check (OS X 10.9.4; Ubuntu 14.04 amd64) > > > Thanks, > > Alexander Rukletsov > >
