----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25434/#review53038 -----------------------------------------------------------
src/exec/exec.cpp <https://reviews.apache.org/r/25434/#comment92392> Maybe I'm missing something, but is there a reason we don't check before a delay? If ShutdownProcess is spawned, it's possible all other processes in the group have already cleaned up. src/exec/exec.cpp <https://reviews.apache.org/r/25434/#comment92395> Does it make more sense to provide a sane default and log in the case of bad config. Doesn't CHECK_SOME bail? src/launcher/executor.cpp <https://reviews.apache.org/r/25434/#comment92399> Doesn't the flags load export override for env vars that are on the commend line? I would keep the original comment. e.g. cat /etc/mesos/mesos-slave-env.sh export MESOS_containerizers=docker,mesos src/launcher/executor.cpp <https://reviews.apache.org/r/25434/#comment92400> I see we all agree here ;-) src/launcher/executor.cpp <https://reviews.apache.org/r/25434/#comment92402> Same logic as above, do we want to bail on bad config or sane default? Imagine thousands of computers and some depoy script gets botched. src/launcher/executor.cpp <https://reviews.apache.org/r/25434/#comment92404> imho the shutdown timeout logic should be part of a utility function, vs. re-creating in different locations, with subtle differences. src/slave/containerizer/containerizer.hpp <https://reviews.apache.org/r/25434/#comment92407> This is more of a general comment for the gallery, but as signatures keep growing at some point we need to determine a limit and either create a utility class | struct to encapsulate. This appears to be a general theme. src/tests/containerizer.cpp <https://reviews.apache.org/r/25434/#comment92408> Manifest constant please. - Timothy St. Clair On Sept. 9, 2014, 12:54 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25434/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 12:54 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy St. > Clair. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos-git > > > Description > ------- > > The configurable slave's executor_shutdown_grace_period flag is propagated to > Executor and CommandExecutor through an environment variable. Shutdown > timeout in Executor and signal escalation timeout in CommandExecutor are now > dependent on this flag. Each nested timeout is somewhat shorter than the > parent one. > > > Diffs > ----- > > src/exec/exec.cpp 36d1778 > src/launcher/executor.cpp 12ac14b > src/slave/constants.hpp 9030871 > src/slave/constants.cpp e1da5c0 > src/slave/containerizer/containerizer.hpp 8a66412 > src/slave/containerizer/containerizer.cpp 0254679 > src/slave/containerizer/docker.cpp 0febbac > src/slave/containerizer/external_containerizer.cpp efbc68f > src/slave/containerizer/mesos/containerizer.cpp 9d08329 > src/slave/flags.hpp 21e0021 > src/tests/containerizer.cpp a17e1e0 > > Diff: https://reviews.apache.org/r/25434/diff/ > > > Testing > ------- > > make check (OS X 10.9.4; Ubuntu 14.04 amd64) > > > Thanks, > > Alexander Rukletsov > >
