----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54215 -----------------------------------------------------------
Ship it! Great job. src/master/master.cpp <https://reviews.apache.org/r/25866/#comment94218> Only need to set connected=true once. - Adam B On Sept. 22, 2014, 4:50 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25866/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 4:50 p.m.) > > > Review request for mesos, Adam B and Ben Mahler. > > > Bugs: MESOS-1081 and MESOS-1811 > https://issues.apache.org/jira/browse/MESOS-1081 > https://issues.apache.org/jira/browse/MESOS-1811 > > > Repository: mesos-git > > > Description > ------- > > Made consistent what connected and active frameworks/slaves means. > > Fixed MESOS-1811 along the way. > > > Diffs > ----- > > src/master/http.cpp 3f5a01dfddca9cea73563100d88e0c03f600d6b1 > src/master/master.hpp f5d74aef185fad861139186be1cab089f8005a94 > src/master/master.cpp e5d30e9c7ba1ec0cdd640c81610790f3397f3062 > src/tests/fault_tolerance_tests.cpp > 154386044d0247b39d84719d7ff14250682a0695 > src/tests/master_tests.cpp 8e4ec1d85c4530b5421387de55036f7d40ee3180 > > Diff: https://reviews.apache.org/r/25866/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
